• Hans Verkuil's avatar
    media: mc-request.c: allow object_bind in QUEUED state · 1cb13613
    Hans Verkuil authored
    If a request was queued without a control handler object, and
    a control handler object is then created and bound to the request
    when copying controls on request completion, then a WARN_ON in
    mc-request.c is triggered since at that time the request is in
    state QUEUED, and not UPDATING.
    
    But this is too strict, and in this case it must also allow
    binding objects when in state QUEUED.
    
    This patch was unfortunately lost when the "always copy the controls
    on completion" patch was posted, it should have been part of that
    commit.
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Fixes: c3bf5129 ("media: v4l2-ctrls: always copy the controls on completion")
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    1cb13613
mc-request.c 12.5 KB