• Hauke Mehrtens's avatar
    bcma: fix invalid PMU chip control masks · 1f03bf06
    Hauke Mehrtens authored
    Commit b9562545 ("bcma: complete workaround for BCMA43224 and
    BCM4313") introduced the wrong masks for setting the chip control
    registers - the "mask" parameter is inverse.
    
    It should be the mask of bits *not* changed, which is admittedly a bit
    non-intuitive.
    
    The incorrect mask not only causes the driver to not work correctly on
    the chips affected (eg the BCM43224 on the Macbook Air 4,2) but the
    state persists over a soft reset, causing the next boot to not
    necessarily see the device correctly.
    Reported-and-tested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Tested-by: default avatarSeth Forshee <seth.forshee@canonical.com>
    Cc: Hauke Mehrtens <hauke@hauke-m.de>
    Cc: Arend Van Spriel <arend@broadcom.com>
    Cc: Pieter-Paul Giesberts <pieterpg@broadcom.com>
    Cc: Brett Rudley <brudley@broadcom.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    1f03bf06
driver_chipcommon_pmu.c 15 KB