• Michel Lespinasse's avatar
    rbtree: break out of rb_insert_color loop after tree rotation · 1f052865
    Michel Lespinasse authored
    It is a well known property of rbtrees that insertion never requires more
    than two tree rotations.  In our implementation, after one loop iteration
    identified one or two necessary tree rotations, we would iterate and look
    for more.  However at that point the node's parent would always be black,
    which would cause us to exit the loop.
    
    We can make the code flow more obvious by just adding a break statement
    after the tree rotations, where we know we are done.  Additionally, in the
    cases where two tree rotations are necessary, we don't have to update the
    'node' pointer as it wouldn't be used until the next loop iteration, which
    we now avoid due to this break statement.
    Signed-off-by: default avatarMichel Lespinasse <walken@google.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Acked-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
    Cc: Rik van Riel <riel@redhat.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Daniel Santos <daniel.santos@pobox.com>
    Cc: Jens Axboe <axboe@kernel.dk>
    Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    1f052865
rbtree.c 10.5 KB