• Masahiro Yamada's avatar
    tick/nohz: unexport __init-annotated tick_nohz_full_setup() · 23900951
    Masahiro Yamada authored
    EXPORT_SYMBOL and __init is a bad combination because the .init.text
    section is freed up after the initialization. Hence, modules cannot
    use symbols annotated __init. The access to a freed symbol may end up
    with kernel panic.
    
    modpost used to detect it, but it had been broken for a decade.
    
    Commit 28438794 ("modpost: fix section mismatch check for exported
    init/exit sections") fixed it so modpost started to warn it again, then
    this showed up:
    
        MODPOST vmlinux.symvers
      WARNING: modpost: vmlinux.o(___ksymtab_gpl+tick_nohz_full_setup+0x0): Section mismatch in reference from the variable __ksymtab_tick_nohz_full_setup to the function .init.text:tick_nohz_full_setup()
      The symbol tick_nohz_full_setup is exported and annotated __init
      Fix this by removing the __init annotation of tick_nohz_full_setup or drop the export.
    
    Drop the export because tick_nohz_full_setup() is only called from the
    built-in code in kernel/sched/isolation.c.
    
    Fixes: ae9e557b
    
     ("time: Export tick start/stop functions for rcutorture")
    Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    Tested-by: default avatarPaul E. McKenney <paulmck@kernel.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    23900951
tick-sched.c 39.6 KB