• Sibi Sankar's avatar
    soc: qcom: icc-bwmon: Fix refcount imbalance seen during bwmon_remove · 24086640
    Sibi Sankar authored
    The following warning is seen during bwmon_remove due to refcount
    imbalance, fix this by releasing the OPPs after use.
    
    Logs:
    WARNING: at drivers/opp/core.c:1640 _opp_table_kref_release+0x150/0x158
    Hardware name: Qualcomm Technologies, Inc. X1E80100 CRD (DT)
    ...
    Call trace:
    _opp_table_kref_release+0x150/0x158
    dev_pm_opp_remove_table+0x100/0x1b4
    devm_pm_opp_of_table_release+0x10/0x1c
    devm_action_release+0x14/0x20
    devres_release_all+0xa4/0x104
    device_unbind_cleanup+0x18/0x60
    device_release_driver_internal+0x1ec/0x228
    driver_detach+0x50/0x98
    bus_remove_driver+0x6c/0xbc
    driver_unregister+0x30/0x60
    platform_driver_unregister+0x14/0x20
    bwmon_driver_exit+0x18/0x524 [icc_bwmon]
    __arm64_sys_delete_module+0x184/0x264
    invoke_syscall+0x48/0x118
    el0_svc_common.constprop.0+0xc8/0xe8
    do_el0_svc+0x20/0x2c
    el0_svc+0x34/0xdc
    el0t_64_sync_handler+0x13c/0x158
    el0t_64_sync+0x190/0x194
    --[ end trace 0000000000000000 ]---
    
    Fixes: 0276f69f ("soc: qcom: icc-bwmon: Set default thresholds dynamically")
    Fixes: b9c2ae6c ("soc: qcom: icc-bwmon: Add bandwidth monitoring driver")
    Signed-off-by: default avatarSibi Sankar <quic_sibis@quicinc.com>
    Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
    Link: https://lore.kernel.org/r/20240613164506.982068-1-quic_sibis@quicinc.comSigned-off-by: default avatarBjorn Andersson <andersson@kernel.org>
    24086640
icc-bwmon.c 28.7 KB