• Jeff Layton's avatar
    cifs: move cifs_new_fileinfo call out of cifs_posix_open · 2422f676
    Jeff Layton authored
    Having cifs_posix_open call cifs_new_fileinfo is problematic and
    inconsistent with how "regular" opens work. It's also buggy as
    cifs_reopen_file calls this function on a reconnect, which creates a new
    struct cifsFileInfo that just gets leaked.
    
    Push it out into the callers. This also allows us to get rid of the
    "mnt" arg to cifs_posix_open.
    
    Finally, in the event that a cifsFileInfo isn't or can't be created, we
    always want to close the filehandle out on the server as the client
    won't have a record of the filehandle and can't actually use it. Make
    sure that CIFSSMBClose is called in those cases.
    Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
    Reviewed-and-Tested-by: default avatarSuresh Jayaraman <sjayaraman@suse.de>
    2422f676
dir.c 23.3 KB