• Arnd Bergmann's avatar
    pcmcia: journada720: use sa1100 pin interfaces correctly · 58409f9d
    Arnd Bergmann authored
    commit dabd1468 "PCMCIA: sa1111: remove duplicated initializers"
    incorrectly moved some code into the pcmcia_jornada720_init, causing
    a few build errors, and for unknown reasons, the driver lacks
    an inclusion of <linux/io.h>, so we get the build errors, and more:
    
    sa1111_jornada720.c: In function 'pcmcia_jornada720_init':
    sa1111_jornada720.c:101:3: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration]
       GRER |= 0x00000002;
       ^
    sa1111_jornada720.c:104:3: warning: passing argument 1 of 'sa1111_set_io_dir' from incompatible pointer type [enabled by default]
       sa1111_set_io_dir(dev, pin, 0, 0);
       ^
    
    This patch uses the SA1111_DEV() to convert the dev pointer to the
    correct type before passing it and adds the missing include.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Cc: Russell King <rmk+kernel@arm.linux.org.uk>
    Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
    Cc: linux-pcmcia@lists.infradead.org
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    58409f9d
sa1111_jornada720.c 2.37 KB