• Julian Braha's avatar
    ASoC: fix unmet dependencies on GPIOLIB for SND_SOC_RT1015P · 2554877e
    Julian Braha authored
    When SND_SOC_MT8192_MT6359_RT1015_RT5682,
    SND_SOC_MT8192_MT6359_RT1015_RT5682,
    SND_SOC_MT8183_DA7219_MAX98357A, or
    SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A is selected,
    and GPIOLIB is not selected, Kbuild gives the following
    warnings, respectively:
    
    WARNING: unmet direct dependencies detected for SND_SOC_DMIC
      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
      Selected by [y]:
      - SND_SOC_MT8192_MT6359_RT1015_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8192 [=y] && MTK_PMIC_WRAP [=y]
    
    WARNING: unmet direct dependencies detected for SND_SOC_RT1015P
      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
      Selected by [y]:
      - SND_SOC_MT8192_MT6359_RT1015_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8192 [=y] && MTK_PMIC_WRAP [=y]
    
    WARNING: unmet direct dependencies detected for SND_SOC_RT1015P
      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
      Selected by [y]:
      - SND_SOC_MT8183_DA7219_MAX98357A [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_MT8183 [=y] && I2C [=y]
    
    WARNING: unmet direct dependencies detected for SND_SOC_RT1015P
      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
      Selected by [y]:
      - SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8183 [=y]
    
    This is because these config options select SND_SOC_RT1015P
    without selecting or depending on GPIOLIB, despite
    SND_SOC_RT1015P depending on GPIOLIB.
    
    These unmet dependency bugs were detected by Kismet,
    a static analysis tool for Kconfig. Please advise if this
    is not the appropriate solution.
    Signed-off-by: default avatarJulian Braha <julianbraha@gmail.com>
    Acked-by: default avatarTzung-Bi Shih <tzungbi@google.com>
    Link: https://lore.kernel.org/r/20211029001225.27218-1-julianbraha@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    2554877e
Kconfig 6.32 KB