• Shashank Sharma's avatar
    drm/i915: prepare csc unit for YCBCR420 output · 25edf915
    Shashank Sharma authored
    To support ycbcr output, we need a pipe CSC block to do
    RGB->YCBCR conversion.
    
    Current Intel platforms have only one pipe CSC unit, so
    we can either do color correction using it, or we can perform
    RGB->YCBCR conversion.
    
    This function adds a csc handler, which uses recommended bspec
    values to perform RGB->YCBCR conversion (target color space BT709)
    
    V2: Rebase
    V3: Rebase
    V4: Rebase
    V5: Addressed review comments from Ander
        - Remove extra line added in the patch
        - Add the spec details in the commit message
        - Combine two if(cond) while calling intel_crtc_compute_config
    V6: Handle YCBCR420 outputs only (Ville)
    V7: Addressed review comments from Ville:
        - Add description about target colorspace
        - Remove the comments from CSC function
        - DRM_DEBUG->DEBUG_KMS for atomic failure due to CSC unit busy
        - Remove unnecessary debug message about YCBCR420 possibe
    V8: Addressed review comments from Ville:
        - Remove extra comment, not required.
        - Do not add extra variable for CTM, reuse pipe_config
        Added r-b from Ville
    V9: Remove extra whitespace (Imre)
    V10: Added r-b from Imre
    
    Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
    Cc: Daniel Vetter <daniel.vetter@intel.com>
    Cc: Ander Conselvan de Oliveira <conselvan2@gmail.com>
    Cc: Imre Deak <imre.deak@intel.com>
    Reviewed-by: default avatarVille Syrjala <ville.syrjala@linux.intel.com>
    Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
    Signed-off-by: default avatarShashank Sharma <shashank.sharma@intel.com>
    Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/1500650709-14447-5-git-send-email-shashank.sharma@intel.comSigned-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    25edf915
intel_color.c 20.4 KB