• Daniel Vetter's avatar
    drm/i915: Invert fastboot check · 26495481
    Daniel Vetter authored
    Fastboot should only downgrade a modeset if we have a match, not be
    used to upgrade to a full modeset. Otherwise we can only use it in a
    very restricted way: Initial modeset when the request mode is the
    preferred one of the panel and there's still a pfit active. And that
    only works because our mode_from_pipe_config fills in the wrong mode
    (it takes the adjusted mode, not the requested one).
    
    But we want fast modesets everywhere even after boot-up (especially
    for testing, but not only there). Hence we need to be able to make any
    modeset a fast one, which means we need to invert the logic and
    optionally downgrade a modeset.
    
    Note that this needs ->connector_changed split out from ->mode_changed
    otherwise it's not going to work (because we might loose a modeset
    because connectors changed but otherwise the config matches). As soon
    as that's merged we can drop the i915.fastboot check from this code.
    
    Also make sure that we don't accidentally clear any_ms and that we add
    the planes for any kind of modeset.
    
    Finally rename fastboot to fastset (yeah it's a silly name) since this
    really isn't about booting all that much.
    
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    26495481
intel_display.c 435 KB