• Nathan Chancellor's avatar
    MIPS: Compare __SYNC_loongson3_war against 0 · 8790ccf8
    Nathan Chancellor authored
    When building with clang when CONFIG_CPU_LOONGSON3_WORKAROUNDS is
    enabled:
    
     In file included from lib/errseq.c:4:
     In file included from ./include/linux/atomic.h:7:
     ./arch/mips/include/asm/atomic.h:52:1: warning: converting the result of
     '<<' to a boolean always evaluates to true
     [-Wtautological-constant-compare]
     ATOMIC_OPS(atomic64, s64)
     ^
     ./arch/mips/include/asm/atomic.h:40:9: note: expanded from macro
     'ATOMIC_OPS'
             return cmpxchg(&v->counter, o, n);
                    ^
     ./arch/mips/include/asm/cmpxchg.h:194:7: note: expanded from macro
     'cmpxchg'
             if (!__SYNC_loongson3_war)
                  ^
     ./arch/mips/include/asm/sync.h:147:34: note: expanded from macro
     '__SYNC_loongson3_war'
     # define __SYNC_loongson3_war   (1 << 31)
                                        ^
    
    While it is not wrong that the result of this shift is always true in a
    boolean context, it is not a problem here. Regardless, the warning is
    really noisy so rather than making the shift a boolean implicitly, use
    it in an equality comparison so the shift is used as an integer value.
    
    Fixes: 4d1dbfe6 ("MIPS: atomic: Emit Loongson3 sync workarounds within asm")
    Fixes: a91f2a1d ("MIPS: cmpxchg: Omit redundant barriers for Loongson3")
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Acked-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
    8790ccf8
atomic.h 7.86 KB