• Tejun Heo's avatar
    freezer: add missing mb's to freezer_count() and freezer_should_skip() · 26e5f795
    Tejun Heo authored
    commit dd67d32d upstream.
    
    A task is considered frozen enough between freezer_do_not_count() and
    freezer_count() and freezers use freezer_should_skip() to test this
    condition.  This supposedly works because freezer_count() always calls
    try_to_freezer() after clearing %PF_FREEZER_SKIP.
    
    However, there currently is nothing which guarantees that
    freezer_count() sees %true freezing() after clearing %PF_FREEZER_SKIP
    when freezing is in progress, and vice-versa.  A task can escape the
    freezing condition in effect by freezer_count() seeing !freezing() and
    freezer_should_skip() seeing %PF_FREEZER_SKIP.
    
    This patch adds smp_mb()'s to freezer_count() and
    freezer_should_skip() such that either %true freezing() is visible to
    freezer_count() or !PF_FREEZER_SKIP is visible to
    freezer_should_skip().
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Rafael J. Wysocki <rjw@sisk.pl>
    [bwh: Backported to 3.2:
     - Adjust context and indentation
     - freezer_do_not_count() and freezer_count() are no-ops for kernel tasks]
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    26e5f795
freezer.h 6.99 KB