• Linus Torvalds's avatar
    i915: temporary fix for DP MST docking station NULL pointer dereference · 27667f47
    Linus Torvalds authored
    Ted Ts'o reports that his Lenovo T540p ThinkPad crashes at boot if
    attached to the docking station.  This is a regression that he was able
    to bisect to commit 8c7b5ccb: "drm/i915: Use atomic helpers for
    computing changed flags:"
    
    The reason seems to be the new call to drm_atomic_helper_check_modeset()
    added to intel_modeset_compute_config(), which in turn calls
    update_connector_routing(), and somehow ends up picking a NULL crtc for
    the connector state, causing the subsequent drm_crtc_index() to OOPS.
    
    Daniel Vetter says that the fundamental issue seems to be confusion in
    the encoder selection, and this isn't the right fix, but while he chases
    down the proper fix, this at least avoids the NULL pointer dereference
    and makes Ted's docking station work again.
    Reported-bisected-and-tested-by: default avatarTheodore Ts'o <tytso@mit.edu>
    Cc: Daniel Vetter <daniel.vetter@intel.com>
    Cc: Mani Nikula <jani.nikula@linux.intel.com>
    Cc: Dave Airlie <airlied@gmail.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    27667f47
drm_atomic_helper.c 64 KB