• Arnd Bergmann's avatar
    gadgetfs: fix uninitialized variable in error handling · 279b8b78
    Arnd Bergmann authored
    gcc warns about a bug in 3.18.y:
    
    drivers/usb/gadget/legacy/inode.c:648:10: warning: 'value' may be used
    
    This is caused by the backport of f01d35a1 from 4.0 to 3.18:
    c81fc59b gadgetfs: use-after-free in ->aio_read()
    
    The backported patch was buggy, but the mainline code was rewritten
    in a larger patch directly following this one in a way that fixed the
    bug.
    
    For stable, we should need only a one-line change to make sure we
    return an proper error code. It is very unlikely that anybody ever
    ran into the out-of-memory case here in practice, but the compiler
    is right in theory.
    
    Fixes: c81fc59b ("gadgetfs: use-after-free in ->aio_read()")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    279b8b78
inode.c 52.6 KB