• Luis R. Rodriguez's avatar
    x86/mm/pat, drivers/media/ivtv: Move the PAT warning and replace WARN() with pr_warn() · f5530d5a
    Luis R. Rodriguez authored
    On built-in kernels this warning will always splat, even if no ivtvfb
    hardware is present, as this is part of the module init:
    
    	if (WARN(pat_enabled(),
    		 "ivtvfb needs PAT disabled, boot with nopat kernel parameter\n")) {
    
    Fix that by shifting the PAT requirement check out under the code
    that does the "quasi-probe" for the device.
    
    This device driver relies on an existing driver to find its own devices,
    it looks for that device driver and its own found devices, then uses
    driver_for_each_device() to try to see if it can probe each of those
    devices as a frambuffer device with ivtvfb_init_card().
    
    We tuck the PAT requiremenet check then on the ivtvfb_init_card() call
    making the check at least require an ivtv device present before
    complaining.
    
    Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
    Signed-off-by: default avatarLuis R. Rodriguez <mcgrof@suse.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: andy@silverblocksystems.net
    Cc: benh@kernel.crashing.org
    Cc: bp@suse.de
    Cc: dan.j.williams@intel.com
    Cc: dledford@redhat.com
    Cc: jkosina@suse.cz
    Cc: julia.lawall@lip6.fr
    Cc: luto@amacapital.net
    Cc: mchehab@osg.samsung.com
    Link: http://lkml.kernel.org/r/1437167245-28273-3-git-send-email-mcgrof@do-not-panic.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    f5530d5a
ivtvfb.c 36.1 KB