• Linus Torvalds's avatar
    xen: Fix annoying compile-time warning · 16757372
    Linus Torvalds authored
    Commit cb6b6df1 ("xen/pv-on-hvm kexec: add quirk for Xen 3.4 and
    shutdown watches.") added the xen_strict_xenbus_quirk() function with an
    old K&R-style declaration without proper typing, causing gcc to rightly
    complain:
    
      drivers/xen/xenbus/xenbus_xs.c:628:13: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
    
    because we really don't live in caves using stone-age tools any more,
    and the kernel has always used properly typed ANSI C function
    declarations.
    
    So if a function doesn't take arguments, we tell the compiler so
    explicitly by adding the proper "void" in the prototype.
    
    I'm sure there are tons of other examples of this kind of stuff in the
    tree, but this is the one that hits my workstation config, so..
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    16757372
xenbus_xs.c 21.3 KB