• Stafford Horne's avatar
    openrisc: Fix cache API compile issue when not inlining · 2c01af4f
    Stafford Horne authored
    [ Upstream commit 3ae90d76 ]
    
    I found this when compiling a kbuild random config with GCC 11.  The
    config enables CONFIG_DEBUG_SECTION_MISMATCH, which sets CFLAGS
    -fno-inline-functions-called-once. This causes the call to cache_loop in
    cache.c to not be inlined causing the below compile error.
    
        In file included from arch/openrisc/mm/cache.c:13:
        arch/openrisc/mm/cache.c: In function 'cache_loop':
        ./arch/openrisc/include/asm/spr.h:16:27: warning: 'asm' operand 0 probably does not match constraints
           16 | #define mtspr(_spr, _val) __asm__ __volatile__ (  \
    	  |                           ^~~~~~~
        arch/openrisc/mm/cache.c:25:3: note: in expansion of macro 'mtspr'
           25 |   mtspr(reg, line);
    	  |   ^~~~~
        ./arch/openrisc/include/asm/spr.h:16:27: error: impossible constraint in 'asm'
           16 | #define mtspr(_spr, _val) __asm__ __volatile__ (  \
    	  |                           ^~~~~~~
        arch/openrisc/mm/cache.c:25:3: note: in expansion of macro 'mtspr'
           25 |   mtspr(reg, line);
    	  |   ^~~~~
        make[1]: *** [scripts/Makefile.build:283: arch/openrisc/mm/cache.o] Error 1
    
    The asm constraint "K" requires a immediate constant argument to mtspr,
    however because of no inlining a register argument is passed causing a
    failure.  Fix this by using __always_inline.
    
    Link: https://lore.kernel.org/lkml/202008200453.ohnhqkjQ%25lkp@intel.com/Signed-off-by: default avatarStafford Horne <shorne@gmail.com>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    2c01af4f
cache.c 1.7 KB