• Kees Cook's avatar
    hinic: Replace memcpy() with direct assignment · 2c0ab32b
    Kees Cook authored
    Under CONFIG_FORTIFY_SOURCE=y and CONFIG_UBSAN_BOUNDS=y, Clang is bugged
    here for calculating the size of the destination buffer (0x10 instead of
    0x14). This copy is a fixed size (sizeof(struct fw_section_info_st)), with
    the source and dest being struct fw_section_info_st, so the memcpy should
    be safe, assuming the index is within bounds, which is UBSAN_BOUNDS's
    responsibility to figure out.
    
    Avoid the whole thing and just do a direct assignment. This results in
    no change to the executable code.
    
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Eric Dumazet <edumazet@google.com>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: Paolo Abeni <pabeni@redhat.com>
    Cc: Nathan Chancellor <nathan@kernel.org>
    Cc: Nick Desaulniers <ndesaulniers@google.com>
    Cc: Tom Rix <trix@redhat.com>
    Cc: Leon Romanovsky <leon@kernel.org>
    Cc: Jiri Pirko <jiri@nvidia.com>
    Cc: Vladimir Oltean <olteanv@gmail.com>
    Cc: Simon Horman <simon.horman@corigine.com>
    Cc: netdev@vger.kernel.org
    Cc: llvm@lists.linux.dev
    Link: https://github.com/ClangBuiltLinux/linux/issues/1592Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    Reviewed-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
    Tested-by: Nathan Chancellor <nathan@kernel.org> # build
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2c0ab32b
hinic_devlink.c 16.6 KB