• David Howells's avatar
    netfs: Fix AIO error handling when doing write-through · 2c6b5310
    David Howells authored
    If an error occurs whilst we're doing an AIO write in write-through mode,
    we may end up calling ->ki_complete() *and* returning an error from
    ->write_iter().  This can result in either a UAF (the ->ki_complete() func
    pointer may get overwritten, for example) or a refcount underflow in
    io_submit() as ->ki_complete is called twice.
    
    Fix this by making netfs_end_writethrough() - and thus
    netfs_perform_write() - unconditionally return -EIOCBQUEUED if we're doing
    an AIO write and wait for completion if we're not.
    
    Fixes: 288ace2f ("netfs: New writeback implementation")
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Link: https://lore.kernel.org/r/295052.1716298587@warthog.procyon.org.uk
    cc: Jeff Layton <jlayton@kernel.org>
    cc: Enzo Matsumiya <ematsumiya@suse.de>
    cc: netfs@lists.linux.dev
    cc: v9fs@lists.linux.dev
    cc: linux-afs@lists.infradead.org
    cc: linux-cifs@vger.kernel.org
    cc: linux-fsdevel@vger.kernel.org
    Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
    2c6b5310
write_issue.c 19.5 KB