• Jon Paul Maloy's avatar
    tipc: eliminate unnecessary call to broadcast ack function · 2cdf3918
    Jon Paul Maloy authored
    The unicast packet header contains a broadcast acknowledge sequence
    number, that may need to be conveyed to the broadcast link for proper
    treatment. Currently, the function tipc_rcv(), which is on the most
    critical data path, calls the function tipc_bclink_acknowledge() to
    have this done. This call is made for each received packet, and results
    in the unconditional grabbing of the broadcast link spinlock.
    
    This is unnecessary, since we can see directly from tipc_rcv() if
    the acknowledged number differs from what has been previously acked
    from the node in question. In the vast majority of cases the numbers
    won't differ, and there is nothing to update.
    
    We now make the call to tipc_bclink_acknowledge() conditional
    to that the two ack values differ.
    Reviewed-by: default avatarErik Hugne <erik.hugne@ericsson.com>
    Reviewed-by: default avatarYing Xue <ying.xue@windriver.com>
    Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2cdf3918
link.c 62.8 KB