• Benjamin Poirier's avatar
    scsi: bfa: Increase requested firmware version to 3.2.5.1 · 2d1148f0
    Benjamin Poirier authored
    bna & bfa firmware version 3.2.5.1 was submitted to linux-firmware on
    Feb 17 19:10:20 2015 -0500 in 0ab54ff1dc ("linux-firmware: Add QLogic BR
    Series Adapter Firmware").
    
    bna was updated to use the newer firmware on Feb 19 16:02:32 2015 -0500 in
    3f307c3d ("bna: Update the Driver and Firmware Version")
    
    bfa was not updated. I presume this was an oversight but it broke support
    for bfa+bna cards such as the following
    	04:00.0 Fibre Channel [0c04]: Brocade Communications Systems, Inc.
    		1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)
    	04:00.1 Fibre Channel [0c04]: Brocade Communications Systems, Inc.
    		1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)
    	04:00.2 Ethernet controller [0200]: Brocade Communications Systems,
    		Inc. 1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)
    	04:00.3 Ethernet controller [0200]: Brocade Communications Systems,
    		Inc. 1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)
    
    Currently, if the bfa module is loaded first, bna fails to probe the
    respective devices with
    [  215.026787] bna: QLogic BR-series 10G Ethernet driver - version: 3.2.25.1
    [  215.043707] bna 0000:04:00.2: bar0 mapped to ffffc90001fc0000, len 262144
    [  215.060656] bna 0000:04:00.2: initialization failed err=1
    [  215.073893] bna 0000:04:00.3: bar0 mapped to ffffc90002040000, len 262144
    [  215.090644] bna 0000:04:00.3: initialization failed err=1
    
    Whereas if bna is loaded first, bfa fails with
    [  249.592109] QLogic BR-series BFA FC/FCOE SCSI driver - version: 3.2.25.0
    [  249.610738] bfa 0000:04:00.0: Running firmware version is incompatible with the driver version
    [  249.833513] bfa 0000:04:00.0: bfa init failed
    [  249.833919] scsi host6: QLogic BR-series FC/FCOE Adapter, hwpath: 0000:04:00.0 driver: 3.2.25.0
    [  249.841446] bfa 0000:04:00.1: Running firmware version is incompatible with the driver version
    [  250.045449] bfa 0000:04:00.1: bfa init failed
    [  250.045962] scsi host7: QLogic BR-series FC/FCOE Adapter, hwpath: 0000:04:00.1 driver: 3.2.25.0
    
    Increase bfa's requested firmware version. Also increase the driver
    version.  I only tested that all of the devices probe without error.
    Reported-by: default avatarTim Ehlers <tehlers@gwdg.de>
    Signed-off-by: default avatarBenjamin Poirier <bpoirier@suse.com>
    Acked-by: default avatarRasesh Mody <rasesh.mody@cavium.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    2d1148f0
bfad.c 46.1 KB