• Tao Ma's avatar
    blktrace: Remove blk_fill_rwbs_rq. · 2d3a8497
    Tao Ma authored
    If we enable trace events to trace block actions, We use
    blk_fill_rwbs_rq to analyze the corresponding actions
    in request's cmd_flags, but we only choose the minor 2 bits
    from it, so most of other flags(e.g, REQ_SYNC) are missing.
    For example, with a sync write we get:
    write_test-2409  [001]   160.013869: block_rq_insert: 3,64 W 0 () 258135 + =
    8 [write_test]
    
    Since now we have integrated the flags of both bio and request,
    it is safe to pass rq->cmd_flags directly to blk_fill_rwbs and
    blk_fill_rwbs_rq isn't needed any more.
    
    With this patch, after a sync write we get:
    write_test-2417  [000]   226.603878: block_rq_insert: 3,64 WS 0 () 258135 +=
     8 [write_test]
    Signed-off-by: default avatarTao Ma <boyu.mt@taobao.com>
    Acked-by: default avatarJeff Moyer <jmoyer@redhat.com>
    Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
    2d3a8497
block.h 15.6 KB