• Thomas Huth's avatar
    KVM: arm64: Limit length in kvm_vm_ioctl_mte_copy_tags() to INT_MAX · 2def950c
    Thomas Huth authored
    In case of success, this function returns the amount of handled bytes.
    However, this does not work for large values: The function is called
    from kvm_arch_vm_ioctl() (which still returns a long), which in turn
    is called from kvm_vm_ioctl() in virt/kvm/kvm_main.c. And that function
    stores the return value in an "int r" variable. So the upper 32-bits
    of the "long" return value are lost there.
    
    KVM ioctl functions should only return "int" values, so let's limit
    the amount of bytes that can be requested here to INT_MAX to avoid
    the problem with the truncated return value. We can then also change
    the return type of the function to "int" to make it clearer that it
    is not possible to return a "long" here.
    
    Fixes: f0376edb ("KVM: arm64: Add ioctl to fetch/store tags in a guest")
    Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
    Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
    Reviewed-by: default avatarGavin Shan <gshan@redhat.com>
    Reviewed-by: default avatarSteven Price <steven.price@arm.com>
    Message-Id: <20230208140105.655814-5-thuth@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    2def950c
api.rst 291 KB