• Hans de Goede's avatar
    ACPI / video: Refactor and fix dmi_is_desktop() · 2df541d0
    Hans de Goede authored
    [ Upstream commit cecf3e3e ]
    
    This commit refactors the chassis-type detection introduced by
    commit 53fa1f6e ("ACPI / video: Only default only_lcd to true on
    Win8-ready _desktops_") (where desktop means anything without a builtin
    screen).
    
    The DMI chassis_type is an unsigned integer, so rather then doing a
    whole bunch of string-compares on it, convert it to an int and feed
    the result to a switch case.
    
    Note the switch case uses hex values, this is done because the spec
    uses hex values too. This changes the check for "Main Server Chassis"
    from checking for 11 decimal to 11 hexadecimal, this is a bug fix,
    the original check for 11 decimal was wrong.
    
    Fixes: 53fa1f6e ("ACPI / video: Only default only_lcd to true ...")
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    [ rjw: Drop redundant return statements ]
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    2df541d0
acpi_video.c 57.9 KB