• Sarah Sharp's avatar
    xhci: Always set urb->status to zero for isoc endpoints. · b3df3f9c
    Sarah Sharp authored
    When the xHCI driver encounters a Missed Service Interval event for an
    isochronous endpoint ring, it means the host controller skipped over
    one or more isochronous TDs.  For TD that is skipped, skip_isoc_td() is
    called.  This sets the frame descriptor status to -EXDEV, and also sets
    the value stored in the int pointed to by status to -EXDEV.
    
    If the isochronous TD happens to be the last TD in an URB,
    handle_tx_event() will use the status variable to give back the URB to
    the USB core.  That means drivers will see urb->status as -EXDEV.
    
    It turns out that EHCI, UHCI, and OHCI always set urb->status to zero for
    an isochronous urb, regardless of what the frame status is.  See
    itd_complete() in ehci-sched.c:
    
                    } else {
                            /* URB was too late */
                            desc->status = -EXDEV;
                    }
            }
    
            /* handle completion now? */
            if (likely ((urb_index + 1) != urb->number_of_packets))
                    goto done;
    
            /* ASSERT: it's really the last itd for this urb
            list_for_each_entry (itd, &stream->td_list, itd_list)
                    BUG_ON (itd->urb == urb);
             */
    
            /* give urb back to the driver; completion often (re)submits */
            dev = urb->dev;
            ehci_urb_done(ehci, urb, 0);
    
    ehci_urb_done() completes the URB with the status of the third argument, which
    is always zero in this case.
    
    It turns out that many USB webcam drivers, such as uvcvideo, cannot
    handle urb->status set to a non-zero value.  They will not resubmit
    their isochronous URBs in that case, and userspace will see a frozen
    video.
    
    Change the xHCI driver to be consistent with the EHCI and UHCI driver,
    and always set urb->status to 0 for isochronous URBs.
    
    This patch should be backported to kernels as old as 2.6.36
    Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
    Cc: "Xu, Andiry" <Andiry.Xu@amd.com>
    Cc: stable@kernel.org
    b3df3f9c
xhci-ring.c 110 KB