• Maciej Falkowski's avatar
    ARM: OMAP1: Fix use of possibly uninitialized irq variable · 3c4e0147
    Maciej Falkowski authored
    The current control flow of IRQ number assignment to `irq` variable
    allows a request of IRQ of unspecified value,
    generating a warning under Clang compilation with omap1_defconfig on
    linux-next:
    
    arch/arm/mach-omap1/pm.c:656:11: warning: variable 'irq' is used
    uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
            else if (cpu_is_omap16xx())
                     ^~~~~~~~~~~~~~~~~
    ./arch/arm/mach-omap1/include/mach/soc.h:123:30: note: expanded from macro
    'cpu_is_omap16xx'
                                            ^~~~~~~~~~~~~
    arch/arm/mach-omap1/pm.c:658:18: note: uninitialized use occurs here
            if (request_irq(irq, omap_wakeup_interrupt, 0, "peripheral wakeup",
                            ^~~
    arch/arm/mach-omap1/pm.c:656:7: note: remove the 'if' if its condition is
    always true
            else if (cpu_is_omap16xx())
                 ^~~~~~~~~~~~~~~~~~~~~~
    arch/arm/mach-omap1/pm.c:611:9: note: initialize the variable 'irq' to
    silence this warning
            int irq;
                   ^
                    = 0
    1 warning generated.
    
    The patch provides a default value to the `irq` variable
    along with a validity check.
    Signed-off-by: default avatarMaciej Falkowski <maciej.falkowski9@gmail.com>
    Link: https://github.com/ClangBuiltLinux/linux/issues/1324Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    3c4e0147
pm.c 18.7 KB