Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
You need to sign in or sign up before continuing.
  • linux
  • kernel
  • futex
  • core.c
Find file BlameHistoryPermalink
  • Peter Zijlstra's avatar
    futex: Fix hardcoded flags · c9bd1568
    Peter Zijlstra authored Nov 14, 2023
    Xi reported that commit 5694289c
    
     ("futex: Flag conversion") broke
    glibc's robust futex tests.
    
    This was narrowed down to the change of FLAGS_SHARED from 0x01 to
    0x10, at which point Florian noted that handle_futex_death() has a
    hardcoded flags argument of 1.
    
    Change this to: FLAGS_SIZE_32 | FLAGS_SHARED, matching how
    futex_to_flags() unconditionally sets FLAGS_SIZE_32 for all legacy
    futex ops.
    
    Reported-by: default avatarXi Ruoyao <xry111@xry111.site>
    Reported-by: default avatarFlorian Weimer <fweimer@redhat.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    Link: https://lkml.kernel.org/r/20231114201402.GA25315@noisy.programming.kicks-ass.net
    Fixes: 5694289c ("futex: Flag conversion")
    Cc: <stable@vger.kernel.org>
    c9bd1568
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7