• Josef Bacik's avatar
    btrfs: fix possible free space tree corruption with online conversion · 2f96e402
    Josef Bacik authored
    While running btrfs/011 in a loop I would often ASSERT() while trying to
    add a new free space entry that already existed, or get an EEXIST while
    adding a new block to the extent tree, which is another indication of
    double allocation.
    
    This occurs because when we do the free space tree population, we create
    the new root and then populate the tree and commit the transaction.
    The problem is when you create a new root, the root node and commit root
    node are the same.  During this initial transaction commit we will run
    all of the delayed refs that were paused during the free space tree
    generation, and thus begin to cache block groups.  While caching block
    groups the caching thread will be reading from the main root for the
    free space tree, so as we make allocations we'll be changing the free
    space tree, which can cause us to add the same range twice which results
    in either the ASSERT(ret != -EEXIST); in __btrfs_add_free_space, or in a
    variety of different errors when running delayed refs because of a
    double allocation.
    
    Fix this by marking the fs_info as unsafe to load the free space tree,
    and fall back on the old slow method.  We could be smarter than this,
    for example caching the block group while we're populating the free
    space tree, but since this is a serious problem I've opted for the
    simplest solution.
    
    CC: stable@vger.kernel.org # 4.9+
    Fixes: a5ed9182 ("Btrfs: implement the free space B-tree")
    Reviewed-by: default avatarFilipe Manana <fdmanana@suse.com>
    Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    2f96e402
free-space-tree.c 39.5 KB