• Heng Qi's avatar
    virtio-net: initially change the value of tx-frames · 3014a0d5
    Heng Qi authored
    Background:
    1. Commit 0c465be1 ("virtio_net: ethtool tx napi configuration") uses
       tx-frames to toggle napi_tx (0 off and 1 on) if notification coalescing
       is not supported.
    2. Commit 31c03aef ("virtio_net: enable napi_tx by default") enables
       napi_tx for all txqs by default.
    
    Status:
    When virtio-net supports notification coalescing, after initialization,
    tx-frames is 0 and napi_tx is true.
    
    Problem:
    When the user only wants to set rx coalescing params using
               ethtool -C eth0 rx-usecs 10, or
    	   ethtool -Q eth0 queue_mask 0x1 -C rx-usecs 10,
    these cmds will carry tx-frames as 0, causing the napi_tx switching condition
    is satisfied. Then the user gets:
               netlink error: Device or resource busy.
    
    The same happens when trying to set rx-frames, adaptive_rx, adaptive_tx...
    
    How to fix:
    When notification coalescing feature is negotiated, initially make the
    value of tx-frames to be consistent with napi_tx.
    
    For compatibility with the past, it is still supported to use tx-frames
    to toggle napi_tx.
    Reported-by: default avatarXiaoming Zhao <zxm377917@alibaba-inc.com>
    Signed-off-by: default avatarHeng Qi <hengqi@linux.alibaba.com>
    Acked-by: default avatarJason Wang <jasowang@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    3014a0d5
virtio_net.c 124 KB