• Chia-Lin Kao (AceLan)'s avatar
    spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP · cff49d58
    Chia-Lin Kao (AceLan) authored
    This commit updates the SPI subsystem, particularly affecting "SPI MEM"
    drivers and core parts, by replacing the -ENOTSUPP error code with
    -EOPNOTSUPP.
    
    The key motivations for this change are as follows:
    1. The spi-nor driver currently uses EOPNOTSUPP, whereas calls to spi-mem
    might return ENOTSUPP. This update aims to unify the error reporting
    within the SPI subsystem for clarity and consistency.
    
    2. The use of ENOTSUPP has been flagged by checkpatch as inappropriate,
    mainly being reserved for NFS-related errors. To align with kernel coding
    standards and recommendations, this change is being made.
    
    3. By using EOPNOTSUPP, we provide more specific context to the error,
    indicating that a particular operation is not supported. This helps
    differentiate from the more generic ENOTSUPP error, allowing drivers to
    better handle and respond to different error scenarios.
    
    Risks and Considerations:
    While this change is primarily intended as a code cleanup and error code
    unification, there is a minor risk of breaking user-space applications
    that rely on specific return codes for unsupported operations. However,
    this risk is considered low, as such use-cases are unlikely to be common
    or critical. Nevertheless, developers and users should be aware of this
    change, especially if they have scripts or tools that specifically handle
    SPI error codes.
    
    This commit does not introduce any functional changes to the SPI subsystem
    or the affected drivers.
    Signed-off-by: default avatar"Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
    Acked-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
    Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
    Acked-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
    Acked-by: default avatarMichael Walle <michael@walle.cc>
    Link: https://lore.kernel.org/r/20231129064311.272422-1-acelan.kao@canonical.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    cff49d58
spi-bcm-qspi.c 44 KB