• Thomas Winter's avatar
    ip/ip6_gre: Fix non-point-to-point tunnel not generating IPv6 link local address · 30e2291f
    Thomas Winter authored
    We recently found that our non-point-to-point tunnels were not
    generating any IPv6 link local address and instead generating an
    IPv6 compat address, breaking IPv6 communication on the tunnel.
    
    Previously, addrconf_gre_config always would call addrconf_addr_gen
    and generate a EUI64 link local address for the tunnel.
    Then commit e5dd7294 changed the code path so that add_v4_addrs
    is called but this only generates a compat IPv6 address for
    non-point-to-point tunnels.
    
    I assume the compat address is specifically for SIT tunnels so
    have kept that only for SIT - GRE tunnels now always generate link
    local addresses.
    
    Fixes: e5dd7294 ("ip/ip6_gre: use the same logic as SIT interfaces when computing v6LL address")
    Signed-off-by: default avatarThomas Winter <Thomas.Winter@alliedtelesis.co.nz>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    30e2291f
addrconf.c 179 KB