• Matt Evans's avatar
    powerpc/perf_event: Fix for power_pmu_disable() · 219a92a4
    Matt Evans authored
    When power_pmu_disable() removes the given event from a particular index into
    cpuhw->event[], it shuffles down higher event[] entries.  But, this array is
    paired with cpuhw->events[] and cpuhw->flags[] so should shuffle them
    similarly.
    
    If these arrays get out of sync, code such as power_check_constraints() will
    fail.  This caused a bug where events were temporarily disabled and then failed
    to be re-enabled; subsequent code tried to write_pmc() with its (disabled) idx
    of 0, causing a message "oops trying to write PMC0".  This triggers this bug on
    POWER7, running a miss-heavy test:
    
      perf record -e L1-dcache-load-misses -e L1-dcache-store-misses ./misstest
    Signed-off-by: default avatarMatt Evans <matt@ozlabs.org>
    Acked-by: default avatarPaul Mackerras <paulus@samba.org>
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    219a92a4
perf_event.c 32.1 KB