• Eric Biggers's avatar
    KEYS: sanitize key structs before freeing · 0620fddb
    Eric Biggers authored
    While a 'struct key' itself normally does not contain sensitive
    information, Documentation/security/keys.txt actually encourages this:
    
         "Having a payload is not required; and the payload can, in fact,
         just be a value stored in the struct key itself."
    
    In case someone has taken this advice, or will take this advice in the
    future, zero the key structure before freeing it.  We might as well, and
    as a bonus this could make it a bit more difficult for an adversary to
    determine which keys have recently been in use.
    
    This is safe because the key_jar cache does not use a constructor.
    Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Signed-off-by: default avatarJames Morris <james.l.morris@oracle.com>
    0620fddb
gc.c 10.1 KB