• Bhumika Goyal's avatar
    [media] media: platform: soc_camera_platform : constify v4l2_subdev_* structures · 32dd9e87
    Bhumika Goyal authored
    v4l2_subdev_{core/video}_ops structures are stored in the
    fields of the v4l2_subdev_ops structure which are of type const.
    Also, v4l2_subdev_ops structure is passed to a function
    having its argument of type const. As these structures are never
    modified, so declare them as const.
    Done using Coccinelle:(One of the scripts)
    
    @r1 disable optional_qualifier @
    identifier i;
    position p;
    @@
    static struct v4l2_subdev_core_ops i@p = {...};
    
    @ok1@
    identifier r1.i;
    position p;
    struct v4l2_subdev_ops obj;
    @@
    obj.core=&i@p;
    
    @bad@
    position p!={r1.p,ok1.p};
    identifier r1.i;
    @@
    i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r1.i;
    @@
    +const
    struct v4l2_subdev_core_ops i;
    
    File size before:
        text   data	    bss	    dec	    hex	filename
        858	    576	      0	   1434	    59a soc_camera/soc_camera_platform.o
    
    File size after:
      text	   data	    bss	    dec	    hex	filename
       1234	    192	      0	   1426	    592 soc_camera/soc_camera_platform.o
    Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
    Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    32dd9e87
soc_camera_platform.c 5.1 KB