• NeilBrown's avatar
    md/raid1: fix test for 'was read error from last working device'. · 34cab6f4
    NeilBrown authored
    When we get a read error from the last working device, we don't
    try to repair it, and don't fail the device.  We simple report a
    read error to the caller.
    
    However the current test for 'is this the last working device' is
    wrong.
    When there is only one fully working device, it assumes that a
    non-faulty device is that device.  However a spare which is rebuilding
    would be non-faulty but so not the only working device.
    
    So change the test from "!Faulty" to "In_sync".  If ->degraded says
    there is only one fully working device and this device is in_sync,
    this must be the one.
    
    This bug has existed since we allowed read_balance to read from
    a recovering spare in v3.0
    Reported-and-tested-by: default avatarAlexander Lyakas <alex.bolshoy@gmail.com>
    Fixes: 76073054 ("md/raid1: clean up read_balance.")
    Cc: stable@vger.kernel.org (v3.0+)
    Signed-off-by: default avatarNeilBrown <neilb@suse.com>
    34cab6f4
raid1.c 86.5 KB