• Qu Wenruo's avatar
    btrfs: use nodesize to determine if we need readahead in btrfs_lookup_bio_sums · 35478d05
    Qu Wenruo authored
    In btrfs_lookup_bio_sums() if the bio is pretty large, we want to
    start readahead in the csum tree.
    
    However the threshold is an immediate number, (PAGE_SIZE * 8), from the
    initial btrfs merge.
    
    The meaning of the value is pretty hard to guess, especially when the
    immediate number is from the times when 4K sectorsize was the default
    and only CRC32C was supported.
    
    For the most common btrfs setup, CRC32 csum and 4K sectorsize,
    it means just 32K read would kick readahead, while the csum itself is
    only 32 bytes in size.
    
    Now let's be more reasonable by taking both csum size and node size into
    consideration.
    
    If the csum size for the bio is larger than one leaf, then we kick the
    readahead.  This means for current default btrfs, the threshold will be
    16M.
    
    This change should not change performance observably, thus this is
    mostly a readability enhancement.
    Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
    Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    35478d05
file-item.c 31 KB