• Daniel Vetter's avatar
    drm/i915: don't update the dri1 breadcrumb with modesetting · 6c719fac
    Daniel Vetter authored
    The update is horribly racy since it doesn't protect at all against
    concurrent closing of the master fd. And it can't really since that
    requires us to grab a mutex.
    
    Instead of jumping through hoops and offloading this to a worker
    thread just block this bit of code for the modesetting driver.
    
    Note that the race is fairly easy to hit since we call the breadcrumb
    function for any interrupt. So the vblank interrupt (which usually
    keeps going for a bit) is enough. But even if we'd block this and only
    update the breadcrumb for user interrupts from the CS we could hit
    this race with kms/gem userspace: If a non-master is waiting somewhere
    (and hence has interrupts enabled) and the master closes its fd
    (probably due to crashing).
    
    v2: Add a code comment to explain why fixing this for real isn't
    really worth it. Also improve the commit message a bit.
    
    v3: Fix the spelling in the comment.
    Reported-by: default avatarEugene Shatokhin <eugene.shatokhin@rosalab.ru>
    Cc: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
    Cc: stable@vger.kernel.org
    Acked-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Tested-by: default avatarEugene Shatokhin <eugene.shatokhin@rosalab.ru>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    6c719fac
i915_dma.c 52.2 KB