• Linus Torvalds's avatar
    Reapply "drm/qxl: simplify qxl_fence_wait" · 3628e038
    Linus Torvalds authored
    This reverts commit 07ed11af.
    
    Stephen Rostedt reports:
     "I went to run my tests on my VMs and the tests hung on boot up.
      Unfortunately, the most I ever got out was:
    
      [   93.607888] Testing event system initcall: OK
      [   93.667730] Running tests on all trace events:
      [   93.669757] Testing all events: OK
      [   95.631064] ------------[ cut here ]------------
      Timed out after 60 seconds"
    
    and further debugging points to a possible circular locking dependency
    between the console_owner locking and the worker pool locking.
    
    Reverting the commit allows Steve's VM to boot to completion again.
    
    [ This may obviously result in the "[TTM] Buffer eviction failed"
      messages again, which was the reason for that original revert. But at
      this point this seems preferable to a non-booting system... ]
    Reported-and-bisected-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Link: https://lore.kernel.org/all/20240502081641.457aa25f@gandalf.local.home/Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
    Cc: Alex Constantino <dreaming.about.electric.sheep@gmail.com>
    Cc: Maxime Ripard <mripard@kernel.org>
    Cc: Timo Lindfors <timo.lindfors@iki.fi>
    Cc: Dave Airlie <airlied@redhat.com>
    Cc: Gerd Hoffmann <kraxel@redhat.com>
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    3628e038
qxl_release.c 11.5 KB