• Yu Kuai's avatar
    block: don't set GD_NEED_PART_SCAN if scan partition failed · 3723091e
    Yu Kuai authored
    Currently if disk_scan_partitions() failed, GD_NEED_PART_SCAN will still
    set, and partition scan will be proceed again when blkdev_get_by_dev()
    is called. However, this will cause a problem that re-assemble partitioned
    raid device will creat partition for underlying disk.
    
    Test procedure:
    
    mdadm -CR /dev/md0 -l 1 -n 2 /dev/sda /dev/sdb -e 1.0
    sgdisk -n 0:0:+100MiB /dev/md0
    blockdev --rereadpt /dev/sda
    blockdev --rereadpt /dev/sdb
    mdadm -S /dev/md0
    mdadm -A /dev/md0 /dev/sda /dev/sdb
    
    Test result: underlying disk partition and raid partition can be
    observed at the same time
    
    Note that this can still happen in come corner cases that
    GD_NEED_PART_SCAN can be set for underlying disk while re-assemble raid
    device.
    
    Fixes: e5cfefa9 ("block: fix scan partition for exclusively open device again")
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
    Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    3723091e
genhd.c 38.3 KB