• M. Vefa Bicakci's avatar
    kconfig: Clear "written" flag to avoid data loss · 3736612d
    M. Vefa Bicakci authored
    commit 0c5b6c28 upstream.
    
    Prior to this commit, starting nconfig, xconfig or gconfig, and saving
    the .config file more than once caused data loss, where a .config file
    that contained only comments would be written to disk starting from the
    second save operation.
    
    This bug manifests itself because the SYMBOL_WRITTEN flag is never
    cleared after the first call to conf_write, and subsequent calls to
    conf_write then skip all of the configuration symbols due to the
    SYMBOL_WRITTEN flag being set.
    
    This commit resolves this issue by clearing the SYMBOL_WRITTEN flag
    from all symbols before conf_write returns.
    
    Fixes: 8e2442a5 ("kconfig: fix missing choice values in auto.conf")
    Cc: linux-stable <stable@vger.kernel.org> # 4.19+
    Signed-off-by: default avatarM. Vefa Bicakci <m.v.b@runbox.com>
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    3736612d
confdata.c 27 KB