-
Sam Ravnborg authored
Hi Richard. I noticed you have set -Werror in all alpha architecture specific makefiles - good initiative. I wish we could do that in general. But the correct way to alter CFLAGS in kbuild makefiles is to use EXTRA_CFLAGS. The following patch fixes this. You could argue that this is a stylistic issue, but in this way you follow Documentation/kbuild/makefiles.txt I stumbled over: EXTRA_AFLAGS := $(CFLAGS) I could not realise the purpose with this assignment, and I noticed that it did not include -Werror, becuse you did hat assignment in the following line. Wanted to inform you about it but I see no problem. It is just that I did not understand it. In math-emu I see this: EXTRA_CFLAGS := -Iinclude/math-emu -w Grepping the src I see no reason to have the -Iinclude/math-emu Relevant files are prefixed with math-emu (soft-fp, single, double) I did not fix it, because I cannot compile alpha. Sam (the Makefile nitpicker) ===== arch/alpha/kernel/Makefile 1.24 vs edited =====
375d43ee