• Florian Fainelli's avatar
    net: bcmgenet: Fix early link interrupt enabling · 37850e37
    Florian Fainelli authored
    Link interrupts are enabled in init_umac(), which is too early for us to
    process them since we do not yet have a valid PHY device pointer. On
    BCM7425 chips for instance, we will crash calling phy_mac_interrupt()
    because phydev is NULL.
    
    Fix this by moving the link interrupts enabling in
    bcmgenet_netif_start(), under a specific function:
    bcmgenet_link_intr_enable() and while at it, update the comments
    surrounding the code.
    
    Fixes: 6cc8e6d4 ("net: bcmgenet: Delay PHY initialization to bcmgenet_open()")
    Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    37850e37
bcmgenet.c 90.3 KB