• Steve Wise's avatar
    svcrdma: handle rdma read with a non-zero initial page offset · c91aed98
    Steve Wise authored
    The server rdma_read_chunk_lcl() and rdma_read_chunk_frmr() functions
    were not taking into account the initial page_offset when determining
    the rdma read length.  This resulted in a read who's starting address
    and length exceeded the base/bounds of the frmr.
    
    The server gets an async error from the rdma device and kills the
    connection, and the client then reconnects and resends.  This repeats
    indefinitely, and the application hangs.
    
    Most work loads don't tickle this bug apparently, but one test hit it
    every time: building the linux kernel on a 16 core node with 'make -j
    16 O=/mnt/0' where /mnt/0 is a ramdisk mounted via NFSRDMA.
    
    This bug seems to only be tripped with devices having small fastreg page
    list depths.  I didn't see it with mlx4, for instance.
    
    Fixes: 0bf48289 ('svcrdma: refactor marshalling logic')
    Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
    Tested-by: default avatarChuck Lever <chuck.lever@oracle.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    c91aed98
svc_rdma_recvfrom.c 19 KB