• Athira Rajeev's avatar
    perf probe: Fix usage when libtraceevent is missing · 3980ee9a
    Athira Rajeev authored
    While parsing the tracepoint events in parse_events_add_tracepoint()
    function, code checks for HAVE_LIBTRACEEVENT support. This is needed
    since libtraceevent is necessary for tracepoint. But while adding probe
    points, check for LIBTRACEEVENT is not done in case of perf probe.
    Hence, in environment with missing libtraceevent-devel, it is observed
    that adding a probe point shows below message though it can't be used
    via perf record.
    
    Example:
    
    Adding probe point:
    	./perf probe 'vfs_getname=getname_flags:72 pathname=result->name:string'
    	Added new event:
    	  probe:vfs_getname    (on getname_flags:72 with pathname=result->name:string)
    
    	You can now use it in all perf tools, such as:
    
    		perf record -e probe:vfs_getname -aR sleep 1
    
    But trying perf record:
    	./perf  record -e probe:vfs_getname -aR sleep 1
    	event syntax error: 'probe:vfs_getname'
    				\___ unsupported tracepoint
    	libtraceevent is necessary for tracepoint support
    	Run 'perf list' for a list of valid events
    
    The builtin tool like perf record needs libtraceevent to
    parse tracefs. But still the probe can be used by enabling
    via tracefs. Patch fixes the probe usage message to the user
    based on presence of libtraceevent. With the fix,
    
     # ./perf probe 'pmu:myprobe=schedule'
     Added new event:
       pmu:myprobe          (on schedule)
    
     perf is not linked with libtraceevent, to use the new probe you can use tracefs:
    
    	cd /sys/kernel/tracing/
    	echo 1 > events/pmu/myprobe/enable
    	echo 1 > tracing_on
    	cat trace_pipe
    	Before removing the probe, echo 0 > events/pmu/myprobe/enable
    Signed-off-by: default avatarAthira Rajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Disha Goel <disgoel@linux.ibm.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kajol Jain <kjain@linux.ibm.com>
    Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Nageswara R Sastry <rnsastry@linux.ibm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: linuxppc-dev@lists.ozlabs.org
    Link: https://lore.kernel.org/r/20230131134748.54567-1-atrajeev@linux.vnet.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    3980ee9a
builtin-probe.c 19.4 KB