• Tony Lindgren's avatar
    power: supply: cpcap-charger: Fix charge voltage configuration · 3ae5f066
    Tony Lindgren authored
    We have the charge voltage wrong, it should be 4.35V instead of 4.2V.
    This will cause the battery to never get fully charged.
    
    I noticed this when looking at the Andoid kernel battery and charger
    status for a fully charged battery:
    
    POWER_SUPPLY_VOLTAGE_NOW=4351000
    
    Also the battery on droid 4 says "4.35, 1735/1785mAh (min/typ),
    6.6/6.8 Wh (min/typ)". Presumably the 4.35 on the battery is the
    charge voltage.
    
    And finally, on Android the CPCAP CRM register is set to 0x03b5 where
    the b is the charge voltage.
    
    Let's fix the charge voltage define and update the charge configuration
    to use the 4.35V setting.
    
    Fixes: 0c9888e3 ("power: supply: cpcap-charger: Add minimal
    CPCAP PMIC battery charger")
    Cc: Marcel Partap <mpartap@gmx.net>
    Cc: Michael Scott <michael.scott@linaro.org>
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
    3ae5f066
cpcap-charger.c 16.9 KB