• Yinghai Lu's avatar
    firmware_map: fix hang with x86/32bit · 3b0fde0f
    Yinghai Lu authored
    Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13484
    
    Peer reported:
    | The bug is introduced from kernel 2.6.27, if E820 table reserve the memory
    | above 4G in 32bit OS(BIOS-e820: 00000000fff80000 - 0000000120000000
    | (reserved)), system will report Int 6 error and hang up. The bug is caused by
    | the following code in drivers/firmware/memmap.c, the resource_size_t is 32bit
    | variable in 32bit OS, the BUG_ON() will be invoked to result in the Int 6
    | error. I try the latest 32bit Ubuntu and Fedora distributions, all hit this
    | bug.
    |======
    |static int firmware_map_add_entry(resource_size_t start, resource_size_t end,
    |                  const char *type,
    |                  struct firmware_map_entry *entry)
    
    and it only happen with CONFIG_PHYS_ADDR_T_64BIT is not set.
    
    it turns out we need to pass u64 instead of resource_size_t for that.
    
    [akpm@linux-foundation.org: add comment]
    Reported-and-tested-by: default avatarPeer Chen <pchen@nvidia.com>
    Signed-off-by: default avatarYinghai Lu <yinghai@kernel.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    Acked-by: default avatarH. Peter Anvin <hpa@zytor.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: <stable@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    3b0fde0f
memmap.c 6.84 KB