• Aaron Lu's avatar
    smp: Avoid sending needless IPI in smp_call_function_many() · 3fc5b3b6
    Aaron Lu authored
    Inter-Processor-Interrupt(IPI) is needed when a page is unmapped and the
    process' mm_cpumask() shows the process has ever run on other CPUs. page
    migration, page reclaim all need IPIs. The number of IPI needed to send
    to different CPUs is especially large for multi-threaded workload since
    mm_cpumask() is per process.
    
    For smp_call_function_many(), whenever a CPU queues a CSD to a target
    CPU, it will send an IPI to let the target CPU to handle the work.
    This isn't necessary - we need only send IPI when queueing a CSD
    to an empty call_single_queue.
    
    The reason:
    
    flush_smp_call_function_queue() that is called upon a CPU receiving an
    IPI will empty the queue and then handle all of the CSDs there. So if
    the target CPU's call_single_queue is not empty, we know that:
    i.  An IPI for the target CPU has already been sent by 'previous queuers';
    ii. flush_smp_call_function_queue() hasn't emptied that CPU's queue yet.
    Thus, it's safe for us to just queue our CSD there without sending an
    addtional IPI. And for the 'previous queuers', we can limit it to the
    first queuer.
    
    To demonstrate the effect of this patch, a multi-thread workload that
    spawns 80 threads to equally consume 100G memory is used. This is tested
    on a 2 node broadwell-EP which has 44cores/88threads and 32G memory. So
    after 32G memory is used up, page reclaiming starts to happen a lot.
    
    With this patch, IPI number dropped 88% and throughput increased about
    15% for the above workload.
    Signed-off-by: default avatarAaron Lu <aaron.lu@intel.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Dave Hansen <dave.hansen@intel.com>
    Cc: Huang Ying <ying.huang@intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Tim Chen <tim.c.chen@linux.intel.com>
    Link: http://lkml.kernel.org/r/20170519075331.GE2084@aaronlu.sh.intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    3fc5b3b6
smp.c 21.3 KB