• Claudio Foellmi's avatar
    i2c: omap: Trigger bus recovery in lockup case · 93367bfc
    Claudio Foellmi authored
    A very conservative check for bus activity (to prevent interference
    in multimaster setups) prevented the bus recovery methods from being
    triggered in the case that SDA or SCL was stuck low.
    This defeats the purpose of the recovery mechanism, which was introduced
    for exactly this situation (a slave device keeping SDA pulled down).
    
    Also added a check to make sure SDA is low before attempting recovery.
    If SDA is not stuck low, recovery will not help, so we can skip it.
    
    Note that bus lockups can persist across reboots. The only other options
    are to reset or power cycle the offending slave device, and many i2c
    slaves do not even have a reset pin.
    
    If we see that one of the lines is low for the entire timeout duration,
    we can actually be sure that there is no other master driving the bus.
    It is therefore save for us to attempt a bus recovery.
    Signed-off-by: default avatarClaudio Foellmi <claudio.foellmi@ergon.ch>
    Tested-by: default avatarVignesh R <vigneshr@ti.com>
    Reviewed-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
    [wsa: fixed one return code to -EBUSY]
    Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
    93367bfc
i2c-omap.c 41.4 KB