• Mark Rutland's avatar
    arm64: lib: __arch_copy_from_user(): fold fixups into body · 4012e0e2
    Mark Rutland authored
    Like other functions, __arch_copy_from_user() places its exception
    fixups in the `.fixup` section without any clear association with
    __arch_copy_from_user() itself. If we backtrace the fixup code, it will
    be symbolized as an offset from the nearest prior symbol, which happens
    to be `__entry_tramp_text_end`. Further, since the PC adjustment for the
    fixup is akin to a direct branch rather than a function call,
    __arch_copy_from_user() itself will be missing from the backtrace.
    
    This is confusing and hinders debugging. In general this pattern will
    also be problematic for CONFIG_LIVEPATCH, since fixups often return to
    their associated function, but this isn't accurately captured in the
    stacktrace.
    
    To solve these issues for assembly functions, we must move fixups into
    the body of the functions themselves, after the usual fast-path returns.
    This patch does so for __arch_copy_from_user().
    
    Inline assembly will be dealt with in subsequent patches.
    
    Other than the improved backtracing, there should be no functional
    change as a result of this patch.
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Acked-by: default avatarRobin Murphy <robin.murphy@arm.com>
    Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: James Morse <james.morse@arm.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Will Deacon <will@kernel.org>
    Link: https://lore.kernel.org/r/20211019160219.5202-3-mark.rutland@arm.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
    4012e0e2
copy_from_user.S 1.37 KB