• Andrij Abyzov's avatar
    serial: 8250_fsl: Fix TX interrupt handling condition · 409cc454
    Andrij Abyzov authored
    This is the port of the commit db1b5bc0 ("serial: 8250: Fix TX
    interrupt handling condition") to the 8250_fsl irq handling logic.
    
    Interrupt handler checked THRE bit (transmitter holding register
    empty) in LSR to detect if TX fifo is empty.
    In case when there is only receive interrupts the TX handling
    got called because THRE bit in LSR is set when there is no
    transmission (FIFO empty). TX handling caused TX stop, which in
    RS-485 half-duplex mode actually resets receiver FIFO. This is not
    desired during reception because of possible data loss.
    
    The fix is to check if THRI is set in IER in addition of the TX
    fifo status. THRI in IER is set when TX is started and cleared
    when TX is stopped.
    This ensures that TX handling is only called when there is really
    transmission on going and an interrupt for THRE and not when there
    are only RX interrupts.
    Signed-off-by: default avatarAndrij Abyzov <aabyzov@slb.com>
    Link: https://lore.kernel.org/r/20200928144127.87156-1-aabyzov@slb.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    409cc454
8250_fsl.c 4.5 KB